Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Fix Onnx.Selu lowering and canonicalizer for IntImplicit op #3221

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

vivekkhandelwal1
Copy link
Collaborator

Signed-Off By: Vivek Khandelwal [email protected]

@vivekkhandelwal1 vivekkhandelwal1 enabled auto-merge (squash) April 25, 2024 18:05
@vivekkhandelwal1 vivekkhandelwal1 merged commit b1e2241 into llvm:main Apr 29, 2024
3 checks passed
@rsuderman
Copy link
Contributor

@vivekkhandelwal1 We should be reverting this. When there is an equivalent operation in the torch dialect we should be relying on it. If the torch implementation is failing the correct choice is to fix it not avoid it. See similar comments about asinh

#3271

rsuderman added a commit to rsuderman/torch-mlir that referenced this pull request May 1, 2024
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants